[rfc][icedtea-web] remember comemnted out lines in deployment.properties

[Jiri Vanek]

On 05/22/2015 03:00 PM, Jie Kang wrote:
>
>
> ----- Original Message -----
>> Hi!
>>
>> Always whern you comment outr something in deployment.properties, then save
>> thsoe via itw-settings,
>> then those comemnts are gonne. Today my patience with it run ou. THis patch
>> is fixing this behaviour.
>
> Hello,
>
> I think this is a good fix :D
>
> First thing that comes to mind though is, can you add tests to verify the new behaviour?

yes. Will add before push.
>
>
> Looking at the code:
>
>
> +                systemComments=loadComments(systemPropertiesFile);
>
> I don't see systemComments being used anywhere else. Is this intended?

Yes.  System proeprties are never stored back. This variable is only for debugging purposes, to see what was in comments during loading of that file.
>
>
> +                comments = comments + "\n" + userComments;
>
> Just curious but, why use "\n" instead of System.lineSeparator()? Not a big deal.

sure, will use!
>
>
> Rest looks okay.
>
>
Thanx.will push later today with unittest and above fixed.

J.