[rfc] added preprocessing to rust launchers

Jiri Vanek jvanek at redhat.com
Wed Dec 6 14:50:02 UTC 2017


Thanx for feedback. I had week long personal battle whether to have it preprocessed with some solid 
defaults, or to use config file. It ehnded 51:49 for preprocess. No it is 99:1 for config file:)

What location do you suggest?

On 12/06/2017 01:12 PM, Alex Kashchenko wrote:
> Hi,
> On 12/05/2017 04:11 PM, Jiri Vanek wrote:
>> This patch is adding the possiblity to pas classapth and simialr to the rust luncher.
>> If there is enybody knowing the better way, and especially how to get rid of this duplicated 
>> (triplicated x triplicated) snipept of
>> +    MAIN_CLASS=net.sourceforge.jnlp.runtime.Boot ;\
>> +    BIN_LOCATION=$(bindir)/$(javaws).sh ;\
>> +    PROGRAM_NAME=$(javaws) ;\
>> +    $(edit_launcher_script) < $< > $@
>> And turn it into function of call(name, suffix)  < $< > $@, that would be awesome. I tried many 
>> times, various ways, but if I get rid of those three lines, I always duplicated  targets:(
> I can suggest not to pre-process .rs file, but to preprocess config file instead and read it on 
> startup.

Jiri Vanek
Senior QE engineer, OpenJDK QE lead, Mgr.
Red Hat Czech
jvanek at redhat.com    M: +420775390109

More information about the distro-pkg-dev mailing list