[rfc][icedtea-web] improved home finding to use variables first

[Alex Kashchenko]

On 12/03/2018 02:33 PM, Jiri Vanek wrote:
> On 11/30/18 5:41 PM, Alex Kashchenko wrote:
>> Hi,
>>
>> On 11/29/2018 12:32 PM, Jiri Vanek wrote:
>>>
>>
>> env::home_dir is deprecated since 1.29, it should not be used in get_home.
>>
>> Probing for HOME and USERPROFILE should be OS-specific (to not pickup HOME on windows).
>>
> 
> 
> Here you go!
> 
> The number of os-specific functions is growing :(

Looks good, except the usage of a deprecated env::home_dir inside 
get_home, please use something like this instead:

type c_char = i8;
type uid_t = u32;
type gid_t = u32;
#[repr(C)]
struct passwd {
     pub pw_name: *mut c_char,
     pub pw_passwd: *mut c_char,
     pub pw_uid: uid_t,
     pub pw_gid: gid_t,
     pub pw_gecos: *mut c_char,
     pub pw_dir: *mut c_char,
     pub pw_shell: *mut c_char,
}
extern {
     fn getuid() -> uid_t;
     fn getpwuid(uid: uid_t) -> *mut passwd;
}
fn pw_home() -> Option<String> {
     unsafe {
         let uid = getuid();
         let pwd = getpwuid(uid);
         if !pwd.is_null() {
             let ptr = (*pwd).pw_dir;
             let cstr = std::ffi::CStr::from_ptr(ptr);
             let st = cstr.to_str().expect("Invalid pw_dir entry");
             Some(st.to_string())
         } else {
             None
         }
     }
}

-- 
-Alex