[rfc][icedtea-web] improved home finding to use variables first

[Jiri Vanek]

On 12/4/18 1:44 PM, Alex Kashchenko wrote:
> On 12/03/2018 02:33 PM, Jiri Vanek wrote:
>> On 11/30/18 5:41 PM, Alex Kashchenko wrote:
>>> Hi,
>>>
>>> On 11/29/2018 12:32 PM, Jiri Vanek wrote:
>>>>
>>>
>>> env::home_dir is deprecated since 1.29, it should not be used in get_home.
>>>
>>> Probing for HOME and USERPROFILE should be OS-specific (to not pickup HOME on windows).
>>>
>>
>>
>> Here you go!
>>
>> The number of os-specific functions is growing :(
> 
> Looks good, except the usage of a deprecated env::home_dir inside get_home, please use something
> like this instead:

Oh pleeeease.... I think it is much nicer to survive one deprecation, especially when the direction
was made clear exactly by following the deprection pointers.
Are you sure you want this duplicate from env::home_dir  instead of  callto env::home_dir?
How will windows counterpart handle home?
> 
> type c_char = i8;
> type uid_t = u32;
> type gid_t = u32;
> #[repr(C)]
> struct passwd {
>     pub pw_name: *mut c_char,
>     pub pw_passwd: *mut c_char,
>     pub pw_uid: uid_t,
>     pub pw_gid: gid_t,
>     pub pw_gecos: *mut c_char,
>     pub pw_dir: *mut c_char,
>     pub pw_shell: *mut c_char,
> }
> extern {
>     fn getuid() -> uid_t;
>     fn getpwuid(uid: uid_t) -> *mut passwd;
> }
> fn pw_home() -> Option<String> {
>     unsafe {
>         let uid = getuid();
>         let pwd = getpwuid(uid);
>         if !pwd.is_null() {
>             let ptr = (*pwd).pw_dir;
>             let cstr = std::ffi::CStr::from_ptr(ptr);
>             let st = cstr.to_str().expect("Invalid pw_dir entry");
>             Some(st.to_string())
>         } else {
>             None
>         }
>     }
> }
> 


-- 
Jiri Vanek
Senior QE engineer, OpenJDK QE lead, Mgr.
Red Hat Czech
jvanek at redhat.com    M: +420775390109