post [rfc] [itw] refactoring of few methods

[Jiri Vanek]

On 1/15/19 8:37 PM, Alex Kashchenko wrote:
> Hi,
> 
> On 1/14/19 3:10 PM, Jiri Vanek wrote:
>> Hello!
>>
>> Due to technical issues I had today Morning, I had pushed without review following refactoring:
>> http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2019-January/040863.html
>>
>> Please , accept my aqpologise, and if you can and wish, eyball.
> 
> No problem, the change looks good to me.

TYVM!
> 
>>
>> Also if you have any idea how to refactor get_jdk_from_path, please share/contribute/advice.
> 
> I assume you mean get_jdk_from_given_path_testable - it may be better to move the contents of the
> loop into a separate function.

Yes. And I'm failing to do so:(
> 
>>
>> Thanx !
>>    J.
>>
>>
> 
> 


-- 
Jiri Vanek
Senior QE engineer, OpenJDK QE lead, Mgr.
Red Hat Czech
jvanek at redhat.com    M: +420775390109