RFR(M): Graal PTX enhancements

[Doug Simon @ Oracle]

On Apr 5, 2013, at 11:42 PM, Christian Thalinger <christian.thalinger at oracle.com> wrote:

> 
> On Apr 5, 2013, at 10:46 AM, Morris Meyer <morris.meyer at oracle.com> wrote:
> 
>> Folks,
>> 
>> Could I get a review of my recent PTX enhancements to Graal?   I've changed the tests to have a base class, extended the assembler, and have taken the test coverage of PTX from 2 to 23 tests.
>> 
>> Thanks in advance,
>> 
>>       --morris meyer
>> 
>> WEBREV - http://cr.openjdk.java.net/~morris/Graal-PTX-Enhancements.01
> 
> This is great!
> 
> Looking at:
> 
> graal/com.oracle.graal.compiler.ptx/src/com/oracle/graal/compiler/ptx/PTXLIRGenerator.java
> 
> it seems we need to turn off "Organize imports" in our favorite editor.  Also indenting seems to be an issue.
> 
> I know the answer is "use the mx script to create the IDE configuration" but no everybody is using Eclipse or Netbeans.  We need to find a way to keep this consistent without the help of an IDE (maybe Mercurial push hooks?).

Any suggestions? It will at least have to be something compatible with the Eclipse formatter.

BTW, if need be you can disable/enable the Eclipse formatter for code sections with:

    // @formatter:off

    <code you don;t want auto-formatted>

    // @formatter:on

-Doug