Correctness Issues after adopting latest version of Graal

[Andreas Woess]

Hi Stefan,

one problem I see in the truffle tree is that you have some shared nodes 
in there, namely around Eager{Binary,Unary}PrimitiveNode (you can see 
them in the IGV with -G:Dump=TruffleTree). Please make sure nodes have 
only one parent. I don't know if that is the cause of your problem but 
we should rule that out.

- andreas

On 11/04/14 13:15, Stefan Marr wrote:
> Hi:
>
> On 11 Apr 2014, at 09:42, Stefan Marr <java at stefan-marr.de> wrote:
>
>>> After adopting the latest Graal/Truffle version, I am seeing correctness issues when running on top of Graal.
>> Just a small update: After the latest version of today (d8b9e3761e52), the issues I am seeing are reduced, but not gone.
>> The minimal example I distilled yesterday seems to be fixed, but I still got two benchmarks failing with incorrect results.
> Haven’t been able to distill a small test case, but the two remaining benchmarks that show correctness issues are:
>
>
> ./graal.sh -cp Smalltalk Examples/Benchmarks/BenchmarkHarness.som Bounce 1000 0 1000
>
> and
>
> ./graal.sh -cp Smalltalk:Examples/Benchmarks/Richards/ Examples/Benchmarks/BenchmarkHarness.som Richards 1000 0 100
>
> Best regards
> Stefan
>
>
> PS:
>
> To checkout the relevant branch of TruffleSOM (graal.sh will need you to set $GRAAL_HOME to work out of the box):
>
> git clone --recursive -b exp/greater-than https://github.com/SOM-st/TruffleSOM.git
> ant jar
> ./graal.sh -cp Smalltalk Examples/Benchmarks/BenchmarkHarness.som GreaterThan 1000 0 1000
>
>
> The Truffle patch is at [2], and the relevant code can be checked out with:
>   git clone -b master https://github.com/smarr/graal.git
>