Correctness Issues after adopting latest version of Graal

[Stefan Marr]

Hi Andreas:

On 11 Apr 2014, at 16:23, Andreas Woess <andreas.woess at jku.at> wrote:

> one problem I see in the truffle tree is that you have some shared nodes in there, namely around Eager{Binary,Unary}PrimitiveNode (you can see them in the IGV with -G:Dump=TruffleTree). Please make sure nodes have only one parent. I don’t know if that is the cause of your problem but we should rule that out.

Thanks for having a look.

Indeed, those nodes were shared. I replaced them by nulls.

These ‘eager’ replacements bring quite a bit of performance for TruffleSOM but the tree structure there is a little unusual. The child nodes of the operation nodes  (i.e., addition, multiplication, etc) that are below such an eager wrapper node are not used. The children are evaluated in the wrapper node itself, which can replace itself when not actually plain ints are added, for instance. 

This change has however no impact on the situation.
The same benchmarks have still correctness issues.

Thanks
Stefan


-- 
Stefan Marr
INRIA Lille - Nord Europe
http://stefan-marr.de/research/