Checkstyle AvoidNestedBlocksCheck

Thomas Wuerthinger thomas.wuerthinger at oracle.com
Thu Dec 8 14:59:06 UTC 2016


You can propose a change that changes the check style rule file. - thomas

> On 08 Dec 2016, at 15:54, Andrew Haley <aph at redhat.com> wrote:
> 
> I'm having this rejected:
> 
>        {
>            Label loop = new Label();
>            // Align the main loop
>            masm.align(crb.target.wordSize * 2);
>            masm.bind(loop);
>            masm.ldr(64, temp, AArch64Address.createRegisterOffsetAddress(array1, length, false));
>            masm.ldr(64, rscratch1, AArch64Address.createRegisterOffsetAddress(array2, length, false));
>            masm.eor(64, rscratch1, temp, rscratch1);
>            masm.cbnz(64, rscratch1, breakLabel);
>            masm.add(64, length, length, VECTOR_SIZE);
>            masm.cbnz(64, length, loop);
>        }
> 
> This seems to me like good coding style.  Declaring locally-used variables
> in a block has always been good coding style.  Is it forbidden in Graal?
> 
> Andrew.



More information about the graal-dev mailing list