New PR for AArch64 Address Lowering

[Andrew Dinn]

Last night I submitted a new PR for the AArch64 Address Lowering patch
(which enables use of offset addressing on AArch64-generated code). It
includes changes required to pass the style checker:

  https://github.com/graalvm/graal/pull/222

I had been seeing problems with this patch when running a
jigsaw--enabled netbeans on jdk9 -- exceptions were being thrown when
reading binary file data. I now believe the exceptions were related to
my local disk retaining a combination of old projects and netbeans
config files. Having cleared out these dirs I was able to run and, more
importantly, rerun a netbeans session with no exceptions being thrown. I
also successfully ran some other basic smoke tests, including javac, and
jedit, with no errors. So, I think the patch is ready for merge.

The Travis job for the PR


https://travis-ci.org/graalvm/graal/builds/239644906?utm_source=github_status&utm_medium=notification

appears to have failed with (javac) compiler errors in one of the tests e.g.

/home/travis/build/graalvm/graal/compiler/src/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/HotSpotGraalMBeanTest.java:241:
error: MockResolvedJavaMethod is not abstract and does not override
abstract method isIntrinsicCandidate() in HotSpotResolvedJavaMethod

    private static class MockResolvedJavaMethod implements
HotSpotResolvedJavaMethod {


All three failed build jobs have encountered the same problem. This
looks like it is nothing to do with my changes. I suspect the latest
graal tree is borked.

regards,


Andrew Dinn
-----------
Senior Principal Software Engineer
Red Hat UK Ltd
Registered in England and Wales under Company Registration No. 03798903
Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander