RFR: 8313302: Fix formatting errors on Windows [v3]
Coleen Phillimore
coleenp at openjdk.org
Tue Aug 1 16:31:49 UTC 2023
On Tue, 1 Aug 2023 13:16:17 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:
>> src/hotspot/os/windows/os_windows.cpp line 3382:
>>
>>> 3380: if (Verbose && PrintMiscellaneous) {
>>> 3381: reserveTimer.stop();
>>> 3382: tty->print_cr("reserve_memory of %zx bytes took " JLONG_FORMAT " ms (" JLONG_FORMAT " ticks)", bytes,
>>
>> SIZE_FORMAT.
>
> Regarding SIZE_FORMAT - https://bugs.openjdk.org/browse/JDK-8256379. Some people have been replacing
> uses of SIZE_FORMAT when touching the relevant code for other reasons.
Yes, I think it might be best if people started using %zd rather than adding new SIZE_FORMAT to the code. I haven't figured out the best way to change the rest. If using %zx, I suggest adding 0x%zx.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15063#discussion_r1280885515
More information about the graal-dev
mailing list