RFR: 8313302: Fix formatting errors on Windows [v3]

[Thomas Stüfe]

On Tue 1. Aug 2023 at 18:32, Coleen Phillimore <coleenp at openjdk.org> wrote:

> On Tue, 1 Aug 2023 13:16:17 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:
>
> >> src/hotspot/os/windows/os_windows.cpp line 3382:
> >>
> >>> 3380:     if (Verbose && PrintMiscellaneous) {
> >>> 3381:       reserveTimer.stop();
> >>> 3382:       tty->print_cr("reserve_memory of %zx bytes took "
> JLONG_FORMAT " ms (" JLONG_FORMAT " ticks)", bytes,
> >>
> >> SIZE_FORMAT.
> >
> > Regarding SIZE_FORMAT - https://bugs.openjdk.org/browse/JDK-8256379.
> Some people have been replacing
> > uses of SIZE_FORMAT when touching the relevant code for other reasons.
>
> Yes, I think it might be best if people started using %zd rather than
> adding new SIZE_FORMAT to the code. I haven't figured out the best way to
> change the rest.  If using %zx, I suggest adding 0x%zx.


Pity, I liked those macros. We also lose the ability to compile with older
compilers, e.g. vs2013.

But I really dislike wholesale replacements of X with X prime (newer,
shinier) for aesthetic reasons. I much rather have those replacements we
agree upon be done when code is touched for other reasons.  That causes
much less overhead for update maintainers.

-------------
>
> PR Review Comment:
> https://git.openjdk.org/jdk/pull/15063#discussion_r1280885515
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/graal-dev/attachments/20230801/c0ddd12f/attachment.htm>