RFR: 8308850: Change JVM options with small ranges from 64 to 32 bits, for globals.hpp
David Holmes
dholmes at openjdk.org
Mon Aug 7 02:40:31 UTC 2023
On Fri, 4 Aug 2023 17:41:50 GMT, Afshin Zafari <azafari at openjdk.org> wrote:
> The JVM options that are in range of `int` type are converted in `globals.hpp` and other files where affected.
>
> ### Tests
> tiers 1-4 passed for linux-x64, linux-x64-debug, windows-x64, windows-x64-debug
> tier1 all passed.
I think the basic change from `intx` to `int` is sound - there is no reason for these flags to have a different size depending on the platform. But you need to check any other references to these flags (e.g. printing) are changed appropriately.
The issue of signed versus unsigned is a topic for a different day IMO.
Thanks.
src/hotspot/share/opto/macro.cpp line 1879:
> 1877: // Generate several prefetch instructions.
> 1878: int step_size = AllocatePrefetchStepSize;
> 1879: int distance = AllocatePrefetchDistance;
Ditto no need to change
src/hotspot/share/runtime/globals.hpp line 1104:
> 1102: "Collect information about IndexSets") \
> 1103: \
> 1104: develop(int, FastAllocateSizeLimit, 128*K, \
Ensure the value is either never printed or else the format specifier is updated accordingly.
-------------
Changes requested by dholmes (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/15164#pullrequestreview-1564442865
PR Review Comment: https://git.openjdk.org/jdk/pull/15164#discussion_r1285309321
PR Review Comment: https://git.openjdk.org/jdk/pull/15164#discussion_r1285309479
More information about the graal-dev
mailing list