RFR: 8308850: Change JVM options with small ranges from 64 to 32 bits, for globals.hpp [v2]

Afshin Zafari azafari at openjdk.org
Tue Aug 8 09:22:18 UTC 2023


On Mon, 7 Aug 2023 02:01:55 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Afshin Zafari has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review comments applied.
>
> src/hotspot/share/opto/macro.cpp line 1879:
> 
>> 1877:       // Generate several prefetch instructions.
>> 1878:       int step_size = AllocatePrefetchStepSize;
>> 1879:       int distance = AllocatePrefetchDistance;
> 
> Ditto no need to change

Okay.
Reverted back.

> src/hotspot/share/runtime/globals.hpp line 1104:
> 
>> 1102:           "Collect information about IndexSets")                            \
>> 1103:                                                                             \
>> 1104:   develop(int, FastAllocateSizeLimit, 128*K,                                \
> 
> Ensure the value is either never printed or else the format specifier is updated accordingly.

Okay.
It is only printed in `[Global flags]` printing.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15164#discussion_r1286844903
PR Review Comment: https://git.openjdk.org/jdk/pull/15164#discussion_r1286842588


More information about the graal-dev mailing list