RFR: 8308396: Fix offset_of conversion warnings in runtime code [v5]

Coleen Phillimore coleenp at openjdk.org
Fri May 19 17:20:02 UTC 2023

On Fri, 19 May 2023 15:54:09 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Please review this change to use ByteSize and byte_offset_of() to refer to offsets to metadata and other types that are used in generated code.  This avoids the int narrowing conversion warning for -Wconversion.  There were a couple that I just added an (int) cast instead because these offsets are either being used in other code currently being changed (in oopDesc) or there are too many (like displaced_header_offset_in_bytes) and should be their own change.
>> This change takes a  chunk out of the -Wconversion warnings - see CR for more info.
>> It might be easier and less tedious to review the commits separately.  One commit renames blah_offset_in_bytes to blah_offset, since in_bytes(blah_offset()) is typically used (except in Address constructor which has an overload for ByteSize).
>> Tested with tier1-4, x86 and aarch64, and built linux-x64-zero linux-x64-zero-debug linux-aarch64-debug linux-s390x-open linux-arm32-debug linux-ppc64le-debug linux-riscv64-debug locally.
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>   Fix more indentation and fparain comments.

Thank you for reviewing Amit, Johan and Fred.


PR Comment: https://git.openjdk.org/jdk/pull/14053#issuecomment-1554992892

More information about the graal-dev mailing list