Integrated: 8308396: Fix offset_of conversion warnings in runtime code

Coleen Phillimore coleenp at
Fri May 19 17:20:03 UTC 2023

On Thu, 18 May 2023 22:37:57 GMT, Coleen Phillimore <coleenp at> wrote:

> Please review this change to use ByteSize and byte_offset_of() to refer to offsets to metadata and other types that are used in generated code.  This avoids the int narrowing conversion warning for -Wconversion.  There were a couple that I just added an (int) cast instead because these offsets are either being used in other code currently being changed (in oopDesc) or there are too many (like displaced_header_offset_in_bytes) and should be their own change.
> This change takes a  chunk out of the -Wconversion warnings - see CR for more info.
> It might be easier and less tedious to review the commits separately.  One commit renames blah_offset_in_bytes to blah_offset, since in_bytes(blah_offset()) is typically used (except in Address constructor which has an overload for ByteSize).
> Tested with tier1-4, x86 and aarch64, and built linux-x64-zero linux-x64-zero-debug linux-aarch64-debug linux-s390x-open linux-arm32-debug linux-ppc64le-debug linux-riscv64-debug locally.

This pull request has now been integrated.

Changeset: 265f40b4
Author:    Coleen Phillimore <coleenp at>
Stats:     447 lines in 85 files changed: 11 ins; 9 del; 427 mod

8308396: Fix offset_of conversion warnings in runtime code

Reviewed-by: amitkumar, jsjolen, fparain



More information about the graal-dev mailing list