RFR: 8313396: Portable implementation of FORBID_C_FUNCTION and ALLOW_C_FUNCTION [v2]

[Kim Barrett]

On Mon, 6 Jan 2025 01:35:54 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> If I was going to go that route, I'd be more inclined toward
>> 
>> #if !define(_WINDOWS)
>> #include "forbiddenFunctions_windows.hpp"
>> #else
>> #include "forbiddenFunctions_posix.hpp"
>> #endif
>> 
>> rather than list all (or maybe just a subset) of the posix-like ports.  My
>> inclination is to leave it as-is with OS_HEADERS, since I think that's the
>> "intended" idiom.
>
> Overall I like this change. I appreciate the effort that has been put in to try and find an elegant solution to this problem.
> 
> but having OS specific files created just to include the posix version runs counter to why we have the posix variants in the first place IMO. Please select one of the above approaches so that the new aix/bsd/linux specific files can be removed in favour of the posix one. Thanks.

I disagree. It seems to me that breaking the abstraction like that is just asking for trouble.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22890#discussion_r1906533984