RFR: 8313396: Portable implementation of FORBID_C_FUNCTION and ALLOW_C_FUNCTION [v2]

[Coleen Phillimore]

On Wed, 8 Jan 2025 06:18:01 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Overall I like this change. I appreciate the effort that has been put in to try and find an elegant solution to this problem.
>> 
>> but having OS specific files created just to include the posix version runs counter to why we have the posix variants in the first place IMO. Please select one of the above approaches so that the new aix/bsd/linux specific files can be removed in favour of the posix one. Thanks.
>
> I disagree. It seems to me that breaking the abstraction like that is just asking for trouble.

Yes, I think it's fine to say !WINDOWS instead of listing all the posix ports.  We've been avoiding dispatch files and once it reaches a threshold of too many #ifdef !WINDOWS #include posix.hpp one, then we could add another macro like the OS_CPU one.

Also the copyright script added 2025 for these because they started with 2024 so it's sort of a bug in the script but not really solvable because it doesn't know that you didn't check this in in 2024.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22890#discussion_r1907176766