RFR: 8352675: Support Intel AVX10 converged vector ISA feature detection [v10]
Jatin Bhateja
jbhateja at openjdk.org
Sat May 3 08:08:46 UTC 2025
On Sat, 3 May 2025 07:52:21 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:
>> Jatin Bhateja has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Review comments resolution
>
> src/hotspot/cpu/x86/vm_version_x86.cpp line 2867:
>
>> 2865:
>> 2866: uint64_t VM_Version::CpuidInfo::feature_flags() const {
>> 2867: uint64_t result = 0;
>
> It's unfortunate you migrated away from operating on a local copy. Why don't you declare a local copy (`VM_Version result`) and migrate bit manipulation to bit field accessors on it? `VM_Version::CpuidInfo::feature_flags()` can still return it by value (once you get rid of heap memory allocation, copying becomes trivial).
New implimentation directly modify the feature vector bits though macros.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24329#discussion_r2072346669
More information about the graal-dev
mailing list