RFR: 8352675: Support Intel AVX10 converged vector ISA feature detection [v10]

[Vladimir Ivanov]

On Sat, 3 May 2025 08:06:10 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

>> src/hotspot/cpu/x86/vm_version_x86.cpp line 2867:
>> 
>>> 2865: 
>>> 2866: uint64_t VM_Version::CpuidInfo::feature_flags() const {
>>> 2867:   uint64_t result = 0;
>> 
>> It's unfortunate you migrated away from operating on a local copy. Why don't you declare a local copy (`VM_Version result`) and migrate bit manipulation to bit field accessors on it? `VM_Version::CpuidInfo::feature_flags()` can still return it by value (once you get rid of heap memory allocation, copying becomes trivial).
>
> New implimentation directly modify the feature vector bits though macros.

I prefer explicit accessor calls on corresponding instance fields. 

It's confusing to see `VM_Version::CpuidInfo::feature_flags()` implicitly modifying `_dynamic_features_vector` through macros.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24329#discussion_r2072349610