RFR: 8352675: Support Intel AVX10 converged vector ISA feature detection [v10]

Jatin Bhateja jbhateja at openjdk.org
Sat May 3 08:33:46 UTC 2025


On Sat, 3 May 2025 08:26:19 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:

>> New implimentation directly modify the feature vector bits though macros.
>
> I prefer explicit accessor calls on corresponding instance fields. 
> 
> It's confusing to see `VM_Version::CpuidInfo::feature_flags()` implicitly modifying `_dynamic_features_vector` through macros.

VM_Version::CpuidInfo::feature_flags() is local to x86 targets, how about changing its name to VM_Version::CpuidInfo::install_feature_flags() and use macros ?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24329#discussion_r2072350359


More information about the graal-dev mailing list