RFR: Added section for newcomers
Magnus Ihse Bursie
ihse at openjdk.java.net
Tue Nov 17 09:20:14 UTC 2020
On Tue, 17 Nov 2020 04:26:31 GMT, Jesper Wilhelmsson <jwilhelm at openjdk.org> wrote:
> Added a section to the introduction to set the expectations for new developers in the OpenJDK.
>
> I also moved the mail list section up since it's also relevant in this context and should (imho) be the first thing to learn about when thinking about joining the community.
Looks good! I've added a couple of suggestions; feel free to use them, ignore them (hopefully not :)), or get inspired by them but doing something else.
src/index.md line 55:
> 53: The OpenJDK community is a friendly place. To keep it that way it's important to keep a professional tone in emails and be aware that the community is global. Many different people with different backgrounds collaborate in these lists. Even though English is the required language for all lists, many Participants speak other languages as their native language. A high tolerance for non-perfect English is expected from anyone joining these lists.
> 54:
> 55: You must be in the list to send to the list. Some lists are moderated to keep the content on topic. Each list has its own archive where you can browse older conversations on the list.
Suggestion:
You must be a member of the the list to be able to post to the list. Some lists are moderated to keep the content on topic. Each list has its own archive where you can browse older conversations on the list.
src/index.md line 35:
> 33: ### 3. Find a sponsor
> 34:
> 35: Socializing your change on the mailing lists also prevents the surprise that would otherwise make the community choke on their morning coffee when they see the huge patch in a new, unknown PR. As a new developer in the community you will need to make a few friends that agrees with your change. There are many good reasons to make friends, but the one relevant here is that you'll need a sponsor to approve your change. This is in addition to the reviewers (but can be the same person). The sponsor takes on a larger responsibility for your change than the reviewers, and may need to defend the change in case of later problems. Making people choke on their morning coffee is not the way to make friends.
Maybe add something about how a sponsor can help you create a JBS issue, which is needed to be able to have a PR accepted?
And maybe something about how you, if you continue to contribute high-quality content, is eligible for OpenJDK roles which means you do not need a sponsor.
src/index.md line 27:
> 25: ### 1. Sign the OCA
> 26:
> 27: Oracle are the stewards of the OpenJDK project, and owns the Java brand. In order to make your patch available for review you must first sign the [Oracle Contributor Agreement](https://www.oracle.com/technical-resources/oracle-contributor-agreement.html) (OCA). This agreement gives Oracle and you as a contributor joint copyright interests in the code. You will retain your copyright while also granting those rights to Oracle. If you try to create a PR before you have signed the OCA, you will get instructions telling you to do so, and the PR will not be published until this is done.
Suggestion:
Oracle are the stewards of the OpenJDK project, and owns the Java brand. In order to make your patch available for review you must first sign the [Oracle Contributor Agreement](https://www.oracle.com/technical-resources/oracle-contributor-agreement.html) (OCA). This agreement gives Oracle and you as a contributor joint copyright interests in the code. You will retain your copyright while also granting those rights to Oracle.
When you sign the OCA, please make sure that you specify your GitHub user name in the `Username` field of the OCA. If you try to create a PR before you have signed the OCA, or if you did not specify your GitHub user name, you will get instructions telling you to do so, and the PR will not be published until this is done. OCA registration is a manual process. Please allow for up to several days to have your OCA application processed, even though it's normally processed swiftly.
-------------
Changes requested by ihse (no project role).
PR: https://git.openjdk.java.net/guide/pull/38
More information about the guide-dev
mailing list