RFR: Added section for newcomers [v2]
Jesper Wilhelmsson
jwilhelm at openjdk.java.net
Tue Nov 17 21:18:27 UTC 2020
On Tue, 17 Nov 2020 09:04:52 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:
>> Jesper Wilhelmsson has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - OCA
>>
>> Co-authored-by: Magnus Ihse Bursie <mag at icus.se>
>> - Member of list
>>
>> Co-authored-by: Magnus Ihse Bursie <mag at icus.se>
>
> src/index.md line 35:
>
>> 33: ### 3. Find a sponsor
>> 34:
>> 35: Socializing your change on the mailing lists also prevents the surprise that would otherwise make the community choke on their morning coffee when they see the huge patch in a new, unknown PR. As a new developer in the community you will need to make a few friends that agrees with your change. There are many good reasons to make friends, but the one relevant here is that you'll need a sponsor to approve your change. This is in addition to the reviewers (but can be the same person). The sponsor takes on a larger responsibility for your change than the reviewers, and may need to defend the change in case of later problems. Making people choke on their morning coffee is not the way to make friends.
>
> Maybe add something about how a sponsor can help you create a JBS issue, which is needed to be able to have a PR accepted?
>
> And maybe something about how you, if you continue to contribute high-quality content, is eligible for OpenJDK roles which means you do not need a sponsor.
Yes these are good suggestions. I'll write something up and commit to the PR.
-------------
PR: https://git.openjdk.java.net/guide/pull/38
More information about the guide-dev
mailing list