RFR: Section on PRs [v2]

Kevin Rushforth kcr at openjdk.java.net
Thu Apr 7 18:22:13 UTC 2022


On Wed, 6 Apr 2022 19:25:48 GMT, Jesper Wilhelmsson <jwilhelm at openjdk.org> wrote:

>> Some tips for creating pull requests.
>
> Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Added sentence about keeping PR up to date

I added my comments on the PR before reading the earlier comments by Pavel. I think explaining _why_ you might want to merge shortly before you integrate (and under what circumstances) is a good idea. I don't think we should encourage everyone to switch to using `/integrate NNNNNNN` to ensure that they never let Skara rebase their patch on top of a later target branch than their PR is based off of. For most fixes, as long as the PR is reasonably up to date (for different definitions of reasonable, depending on what is being changed), it just adds overhead for very little real benefit.

-------------

PR: https://git.openjdk.java.net/guide/pull/79


More information about the guide-dev mailing list