RFR: Section on PRs [v2]

Daniel Jeliński djelinski at openjdk.java.net
Thu Apr 7 18:37:55 UTC 2022


On Wed, 6 Apr 2022 19:25:48 GMT, Jesper Wilhelmsson <jwilhelm at openjdk.org> wrote:

>> Some tips for creating pull requests.
>
> Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Added sentence about keeping PR up to date

src/index.md line 1468:

> 1466: After the PR has been published, rebasing, force-pushing, and similar actions is strongly discouraged. Such actions will disrupt the workflow for reviewers who fetch the PR branch. Pushing new changes is fine (and even merging if necessary) for a PR under review. Incremental diffs and other tools will help your reviewers see what you have changed. In the end, all commits will be squashed into a single commit automatically, so there're actually no drawbacks what so ever to making several commits to a PR branch during review.
> 1467: 
> 1468: ## Life of a PR

Could you mention that the PR title has to start with a bug ID? Many first-time contributors are surprised by that.

-------------

PR: https://git.openjdk.java.net/guide/pull/79


More information about the guide-dev mailing list