RFR: Section on PRs [v2]

Magnus Ihse Bursie ihse at openjdk.java.net
Fri Apr 8 11:18:58 UTC 2022


On Thu, 7 Apr 2022 18:35:07 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:

>> Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Added sentence about keeping PR up to date
>
> src/index.md line 1468:
> 
>> 1466: After the PR has been published, rebasing, force-pushing, and similar actions is strongly discouraged. Such actions will disrupt the workflow for reviewers who fetch the PR branch. Pushing new changes is fine (and even merging if necessary) for a PR under review. Incremental diffs and other tools will help your reviewers see what you have changed. In the end, all commits will be squashed into a single commit automatically, so there're actually no drawbacks what so ever to making several commits to a PR branch during review.
>> 1467: 
>> 1468: ## Life of a PR
> 
> Could you mention that the PR title has to start with a bug ID? Many first-time contributors are surprised by that.

In fact, a PR title can be *just* the bug ID -- in that case, Skara will fill in the proper title from JBS, which might be a simpler way to get the correct PR title. (I'm an old-timer though, and always copy the title from JBS manually. Quite silly, actually ;-)).

-------------

PR: https://git.openjdk.java.net/guide/pull/79


More information about the guide-dev mailing list