RFR: Section on PRs [v2]

Pavel Rappo prappo at openjdk.java.net
Fri Apr 8 12:11:00 UTC 2022


On Wed, 6 Apr 2022 19:25:48 GMT, Jesper Wilhelmsson <jwilhelm at openjdk.org> wrote:

>> Some tips for creating pull requests.
>
> Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Added sentence about keeping PR up to date

src/index.md line 1480:

> 1478: #. **Allow enough time for review**
> 1479: 
> 1480:    In general all PRs should be open for at least 24 hours to allow for reviewers in all time zones to get a chance to see it. In some areas [trivial](#trivial) changes are allowed to be pushed without the 24 hour delay. Ask your reviewers if you think this applies to your change.

We could briefly mention that a PR that targets a broader audience should not only consider timezones, but also weekends, national holidays, and in some cases, vacations.

-------------

PR: https://git.openjdk.java.net/guide/pull/79


More information about the guide-dev mailing list