RFR: Section on PRs [v2]
Jesper Wilhelmsson
jwilhelm at openjdk.java.net
Sat Apr 9 01:41:51 UTC 2022
On Fri, 8 Apr 2022 12:07:33 GMT, Pavel Rappo <prappo at openjdk.org> wrote:
>> Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Added sentence about keeping PR up to date
>
> src/index.md line 1480:
>
>> 1478: #. **Allow enough time for review**
>> 1479:
>> 1480: In general all PRs should be open for at least 24 hours to allow for reviewers in all time zones to get a chance to see it. In some areas [trivial](#trivial) changes are allowed to be pushed without the 24 hour delay. Ask your reviewers if you think this applies to your change.
>
> We could briefly mention that a PR that targets a broader audience should not only consider timezones, but also weekends, national holidays, and in some cases, vacations.
Yes, that's a good suggestion!
-------------
PR: https://git.openjdk.java.net/guide/pull/79
More information about the guide-dev
mailing list