RFR: Section on PRs [v4]

Stuart Marks smarks at openjdk.java.net
Wed Apr 13 18:47:37 UTC 2022


On Sat, 9 Apr 2022 11:15:40 GMT, Jesper Wilhelmsson <jwilhelm at openjdk.org> wrote:

>> Some tips for creating pull requests.
>
> Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update src/index.md
>   
>   Co-authored-by: Daniel Jelinski <djelinski1 at gmail.com>

src/index.md line 1508:

> 1506: #. **Make sure all relevant groups are included**
> 1507: 
> 1508:    The bot will make an attempt to include the groups that need to review your change based on the location of the source code you have changed. There may be aspects of your change that are relevant to other groups as well, and the mapping from source to groups isn't always perfect, so make sure all relevant groups have been included, and add new labels using [`/label`](https://wiki.openjdk.java.net/display/SKARA/Pull+Request+Commands#PullRequestCommands-/label) if needed.

I would also add something like,

> If the set of files in the PR has changed, this may affect the groups that need to review the PR. Make sure to adjust the labels accordingly.

(That leads to the question of how to determine the set of labels given files changed. Is there a way to re-run the bot to refresh the labels? I don't know; for now I'm doing it manually. Fortunately this is a pretty rare occurrence, and I don't think we need to cover it here at the moment.)

-------------

PR: https://git.openjdk.java.net/guide/pull/79


More information about the guide-dev mailing list