RFR: Section on PRs [v4]

Stuart Marks smarks at openjdk.java.net
Wed Apr 13 18:43:42 UTC 2022


On Sat, 9 Apr 2022 11:15:40 GMT, Jesper Wilhelmsson <jwilhelm at openjdk.org> wrote:

>> Some tips for creating pull requests.
>
> Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update src/index.md
>   
>   Co-authored-by: Daniel Jelinski <djelinski1 at gmail.com>

src/index.md line 1515:

> 1513: 
> 1514:    At least one reviewer should be knowledgeable in the area being changed. Some areas (e.g. client and hotspot) require two reviewers in most cases, so be sure to read the relevant OpenJDK group pages for advice or ask your sponsor.
> 1515: 

I'm not sure whether it belongs in this section or in a different one (possibly earlier) but maybe there needs to be something said about updating the PR in response to review comments. Something like:

> Updating the PR
> 
>    You may need to change the code in response to review comments. To do this, simply commit new changes and push them onto the PR branch. The PR will be updated automatically. Multiple commits to the branch will be "squashed" into a single commit when the PR is eventually integrated.

-------------

PR: https://git.openjdk.java.net/guide/pull/79


More information about the guide-dev mailing list