RFR: Section on PRs [v4]

[Jesper Wilhelmsson]

On Tue, 12 Apr 2022 03:25:16 GMT, Phil Race <prr at openjdk.org> wrote:

>> Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update src/index.md
>>   
>>   Co-authored-by: Daniel Jelinski <djelinski1 at gmail.com>
>
> src/index.md line 1519:
> 
>> 1517: 
>> 1518:    If your PR is out for review for a longer time it's a good habit to pull from the target repository regularly to keep the change up to date. This will make it easier to review the change and it will help you find issues caused by other changes sooner. If there are upstream changes that might affect your change, it's likely a good idea to rerun relevant testing as well. The GHA testing that is done automatically by GitHub should only be seen as a smoke test that finds the most severe problems with your change. It's highly unlikely that it will test your actual change in any greater detail - or even run the code that you have changed in most cases.
>> 1519: 
> 
> It might be worth noting that this particularly applies to client changes. Not a SINGLE LINE of desktop / client code is exercised by the github actions. It is built, but that is all.
> Otherwise all looks good now.

Client may be the most extreme area in this sense, but in general I think it applies to most areas. Most JDK libraries and JVM features aren't executed at all in the GHA tests AFAIK. These basically only find build errors.

-------------

PR: https://git.openjdk.java.net/guide/pull/79