RFR: Things to consider before PR

Martin Desruisseaux duke at openjdk.org
Sun Apr 23 08:07:08 UTC 2023


On Fri, 21 Apr 2023 16:15:30 GMT, Jesper Wilhelmsson <jwilhelm at openjdk.org> wrote:

> Text about what kind of changes that may or may not be desired in OpenJDK. Based on @prrace's text on https://openjdk.org/groups/client-libs/

In the _"What is the main intention of your change?"_ section, there is no item for _"Reducing code size"_. Would it be an item worth to add? For example in `java.awt.image`, there is:

* Blocks of code repeated in different places, which could have been factored in package-private methods.
* Unnecessary codes overwriting what the default values already provided, for example:
  *  loops for setting all elements to 0 in a newly created array,
  * setting non-final fields to zero in the constructor,
  * invoking constructor with arguments when there is a no-argument constructor providing the desired values.

Should the guide mentions a policy for potential "reducing code size" tasks?

-------------

PR Comment: https://git.openjdk.org/guide/pull/101#issuecomment-1518987582


More information about the guide-dev mailing list