RFR: Things to consider before PR

[Stuart Marks]

On Sun, 23 Apr 2023 08:04:54 GMT, Martin Desruisseaux <duke at openjdk.org> wrote:

> **What is the main intention of your change?**

I think we need more emphasis on this point. What I usually do is ask, "What problem are you trying to solve?" The important thing here is to understand the problem itself, independent of any solution (and independently of the solution that currently happens to be in the PR). A number of other questions and lines of thought emanate from thinking about the problem. For example: is this the _right_ problem to solve? Does solving this problem create worse problems elsewhere; that is, is there a net benefit? Does this problem need to be solved in the JDK, or can and should it be solved elsewhere (e.g., in tooling)?

-------------

PR Comment: https://git.openjdk.org/guide/pull/101#issuecomment-1520673691