RFR: Things to consider before PR

Jesper Wilhelmsson jwilhelm at openjdk.org
Thu Apr 27 20:40:24 UTC 2023


On Mon, 24 Apr 2023 19:00:44 GMT, Stuart Marks <smarks at openjdk.org> wrote:

> What I usually do is ask, "What problem are you trying to solve?"

@stuart-marks Added this, used your words. Thanks!

> An item that would be good to add to the list of things to consider is maintainability.

This is covered in Why is my change rejected?. I can't really fit it into the list of thing to consider since I don't see anyone answering "maintainability" to the intention question. If they do it's probably the same as Refactoring/Cleanup.

> Tradeoffs around performance-related proposals.

Added a few sentences on this.

-------------

PR Comment: https://git.openjdk.org/guide/pull/101#issuecomment-1526364368


More information about the guide-dev mailing list