RFR: Things to consider before PR [v6]

Roger Riggs rriggs at openjdk.org
Fri Apr 28 13:58:55 UTC 2023


On Thu, 27 Apr 2023 22:21:24 GMT, Jesper Wilhelmsson <jwilhelm at openjdk.org> wrote:

>> Text about what kind of changes that may or may not be desired in OpenJDK. Based on @prrace's text on https://openjdk.org/groups/client-libs/
>
> Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Few more updates

Marked as reviewed by rriggs (no project role).

src/guide/working-with-pull-requests.md line 17:

> 15: It's also worth taking the extra time to see if the change can be split into a few different separate changes. A large change will take more effort and thus attract fewer Reviewers. Smaller changes will get reviewed faster and get better quality reviews. You can compare proposing a single large change to proposing ten individual small unrelated changes. What happens in practice when all these ten changes are presented as one PR is that there's a focus on say 5-6 of these smaller changes and no one really looks hard at the other 4-5. For complexity, even small changes that are hard to understand and test may be risky.
> 16: 
> 17: The timing of your change will also affect the availability of reviewers. The JDK runs on a [six-months release cadence](#release-cycle). During the months around the start of the ramp down phase most area experts will be bussy working on their own changes and reviewing major features that are planned for the release. If you propose a change during this period (basically May-June, or November-December) it may take a long time before you get the required reviews.

typo "bussy" -> "busy'

-------------

PR Review: https://git.openjdk.org/guide/pull/101#pullrequestreview-1406008211
PR Review Comment: https://git.openjdk.org/guide/pull/101#discussion_r1180442263


More information about the guide-dev mailing list