RFR: Things to consider before PR [v6]

[Sean Mullan]

On Thu, 27 Apr 2023 22:21:24 GMT, Jesper Wilhelmsson <jwilhelm at openjdk.org> wrote:

>> Text about what kind of changes that may or may not be desired in OpenJDK. Based on @prrace's text on https://openjdk.org/groups/client-libs/
>
> Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Few more updates

src/guide/contributing-to-an-open-jdk-project.md line 13:

> 11: ## Things to consider before proposing changes to OpenJDK code
> 12: 
> 13: Every change in JDK code carries risk of changes in behavior which adversely affect applications. Generally we're looking to improve the functionality and capability and sometimes performance of the platform without that negative consequence. We do have many thousands of tests, but they're inevitably incomplete in coverage. So we need to ask ourselves whether each change is worthwhile - and some may not be no matter how well intentioned.

This sounds like all changes in behavior are negative, which is not true. I suggest inserting "may" before "adversely".

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/101#discussion_r1180510996