RFR: More on testing

[Kim Barrett]

On Mon, 20 Feb 2023 15:32:04 GMT, Jesper Wilhelmsson <jwilhelm at openjdk.org> wrote:

> * Added clarifications and expectations around testing and review
> * Moved GHA section (unchanged)
> * Removed outdated stuff from the glossary

src/guide/hotspot-development.md line 5:

> 3: See [Working With Pull Requests](#working-with-pull-requests) for generic guidance and requirements around pushing changes. For the HotSpot codebase there are a few additional requirements:
> 4: 
> 5: * Your change must have been approved by two Committers out of which at least one is also a Reviewer

The original requirement, from the Oracle-internal wiki ("Hotspot Code Review Guidelines"), was "At least two reviewers (one of which is a Reviewer)".  The "two Committers" requirement suggested here (taken from the openjdk wiki) was a quiet change introduced when the openjdk wiki page was created based on the internal wiki.  In earlier (private) discussion this change was questioned.  We want to encourage thoughtful and knowledgeable reviews even from folks who are new or only lightly connected to the project and so don't have Committer status (yet), rather than effectively saying such reviews don't count for anything in the official process.

src/guide/hotspot-development.md line 7:

> 5: * Your change must have been approved by two Committers out of which at least one is also a Reviewer
> 6: * Your change must have passed through HotSpot tier 1 testing with zero failures (See tier1 definition in `test/hotspot/jtreg/TEST.groups`.)
> 7: 

I thought the 24 hour rule was part of the HotSpot tailoring (present in both the internal and external HotSpot review guidelines), rather than a JDK-wide requirement.  But it's in the generic requirements in the Guide.  Am I misremembering, or is that a change I didn't notice before?

-------------

PR: https://git.openjdk.org/guide/pull/98