RFR: More on testing
Kim Barrett
kbarrett at openjdk.org
Mon Feb 20 19:36:52 UTC 2023
On Mon, 20 Feb 2023 19:11:11 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:
>> * Added clarifications and expectations around testing and review
>> * Moved GHA section (unchanged)
>> * Removed outdated stuff from the glossary
>
> src/guide/hotspot-development.md line 7:
>
>> 5: * Your change must have been approved by two Committers out of which at least one is also a Reviewer
>> 6: * Your change must have passed through HotSpot tier 1 testing with zero failures (See tier1 definition in `test/hotspot/jtreg/TEST.groups`.)
>> 7:
>
> I thought the 24 hour rule was part of the HotSpot tailoring (present in both the internal and external HotSpot review guidelines), rather than a JDK-wide requirement. But it's in the generic requirements in the Guide. Am I misremembering, or is that a change I didn't notice before?
And I don't see the 24 hour rule being strictly adhered to elsewhere. For example, I see the occasional quick turnaround in core-libs changes.
-------------
PR: https://git.openjdk.org/guide/pull/98
More information about the guide-dev
mailing list