RFR: More on testing

[David Holmes]

On Mon, 20 Feb 2023 19:34:38 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> src/guide/hotspot-development.md line 7:
>> 
>>> 5: * Your change must have been approved by two Committers out of which at least one is also a Reviewer
>>> 6: * Your change must have passed through HotSpot tier 1 testing with zero failures (See tier1 definition in `test/hotspot/jtreg/TEST.groups`.)
>>> 7: 
>> 
>> I thought the 24 hour rule was part of the HotSpot tailoring (present in both the internal and external HotSpot review guidelines), rather than a JDK-wide requirement.  But it's in the generic requirements in the Guide.  Am I misremembering, or is that a change I didn't notice before?
>
> And I don't see the 24 hour rule being strictly adhered to elsewhere.  For example, I see the occasional quick turnaround in core-libs changes.

I think the 24 hour rule was hotspot specific. Other areas do very quick turn-arounds.

-------------

PR: https://git.openjdk.org/guide/pull/98