RFR: Updates to the JBS section of the OpenJDK Dev Guide [v9]
Stefan Karlsson
stefank at openjdk.org
Mon May 22 10:28:22 UTC 2023
On Wed, 17 May 2023 21:55:48 GMT, Jesper Wilhelmsson <jwilhelm at openjdk.org> wrote:
>> src/guide/jbs-jdk-bug-system.md line 205:
>>
>>> 203: 1. Bugs that do not affect product code, but are only against the regression test: 'noreg-self'
>>> 204: 1. Issues that seem to be trivial to fix: 'starter'
>>> 205: 1. RFEs that are pure cleanups: 'noreg-cleanup'
>>
>> As I understand it, the noreg- labels are there to indicate the reason why there is *no reg*ression test. So, pure cleanups are typically labeled with 'cleanup' and 'noreg-cleanup' is later used by SQE to note why there's no regression test for the pushed change.
>
> This is correct, but it's not only SQE that are allowed to set the noreg labels on issues. In triage we frequently set noreg-self on any test issues for instance. So I think it is fine for this text to recommend setting noreg-cleanup. Actually we probably could get rid of the cleanup label and only use noreg-cleanup.
I still think it is odd to recommend noreg-cleanup for cleanups instead of the better-named 'cleanup' label.
-------------
PR Review Comment: https://git.openjdk.org/guide/pull/100#discussion_r1200317189
More information about the guide-dev
mailing list