RFR: Updates to the JBS section of the OpenJDK Dev Guide [v9]

Jesper Wilhelmsson jwilhelm at openjdk.org
Mon May 22 20:08:16 UTC 2023


On Mon, 22 May 2023 10:25:40 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> This is correct, but it's not only SQE that are allowed to set the noreg labels on issues. In triage we frequently set noreg-self on any test issues for instance. So I think it is fine for this text to recommend setting noreg-cleanup. Actually we probably could get rid of the cleanup label and only use noreg-cleanup.
>
> I still think it is odd to recommend noreg-cleanup for cleanups instead of the better-named 'cleanup' label.

I agree that "cleanup" is a more approachable name, but we will need the noreg-labels on any fix that doesn't come with a regression test which basically means that all cleanup fixes would have both labels. That seems a bit redundant to me.

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/100#discussion_r1200995852


More information about the guide-dev mailing list