RFR: Updates to the JBS section of the OpenJDK Dev Guide [v9]

Jesper Wilhelmsson jwilhelm at openjdk.org
Tue May 23 19:56:23 UTC 2023


On Mon, 22 May 2023 20:05:10 GMT, Jesper Wilhelmsson <jwilhelm at openjdk.org> wrote:

>> I still think it is odd to recommend noreg-cleanup for cleanups instead of the better-named 'cleanup' label.
>
> I agree that "cleanup" is a more approachable name, but we will need the noreg-labels on any fix that doesn't come with a regression test which basically means that all cleanup fixes would have both labels. That seems a bit redundant to me.

After some discussions and looking at some actual issues we can see that some cleanups actually do have regression tests which means that both labels are needed, and in many cases it would be premature to put noreg-cleanup on cleanup issues already at triage time. The text here should say 'cleanup' as Stefan indicated in his first comment. Thank you Stefan for highlighting this!

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/100#discussion_r1202921660


More information about the guide-dev mailing list