RFR: New section Making a change [v2]

[David Holmes]

On Tue, 9 Jul 2024 06:51:18 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Removed todo entry for the CSR section
>
> src/guide/making-a-change.md line 67:
> 
>> 65: As stated in the header, don't make changes to the copyright notices or the license text below them. If your affiliation has a copyright notice at the top of the header, consult your legal representative on how to update it. If your affiliation doesn't have a copyright notice, again consult your legal representative to see if you should add one. Do not update a copyright notice if you don't belong to that affiliation.
>> 66: 
>> 67: If you create a new file, copy the license text from a nearby file. Do not add copyright notices for affiliations to which you don't belong.
> 
> What if a test was provided by Company X and Company Y includes it in their changeset? They should add the copyright of Company X.

Technically if Company X holds the copyright then Company Y should not be supplying the test as we don't know they have the right to do so. In any case Company X should provide the relevant text for their copyright notice, as (generally speaking) Company Y don't know what form it should take.

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/131#discussion_r1671744279