RFR: New section Making a change [v2]

Tobias Hartmann thartmann at openjdk.org
Tue Jul 9 06:53:43 UTC 2024


On Mon, 8 Jul 2024 23:53:54 GMT, Jesper Wilhelmsson <jwilhelm at openjdk.org> wrote:

>> The old section "Fixing a bug" was mostly outdated so it has been replaced with a section "Making a change" that holds content relevant to working with the source code and making changes. The still relevant parts of Fixing a bug has been moved to the appropriate places.
>> 
>> Another change that followed from this was the new section "Responsibilities of a Reviewer".
>
> Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Removed todo entry for the CSR section

src/guide/making-a-change.md line 67:

> 65: As stated in the header, don't make changes to the copyright notices or the license text below them. If your affiliation has a copyright notice at the top of the header, consult your legal representative on how to update it. If your affiliation doesn't have a copyright notice, again consult your legal representative to see if you should add one. Do not update a copyright notice if you don't belong to that affiliation.
> 66: 
> 67: If you create a new file, copy the license text from a nearby file. Do not add copyright notices for affiliations to which you don't belong.

What if a test was provided by Company X and Company Y includes it in their changeset? They should add the copyright of Company X.

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/131#discussion_r1669843766


More information about the guide-dev mailing list