RFR: New section Making a change [v2]
Jesper Wilhelmsson
jwilhelm at openjdk.org
Fri Jul 26 14:54:23 UTC 2024
On Tue, 9 Jul 2024 00:59:54 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> src/guide/reviewing-and-sponsoring-a-change.md line 21:
>>
>>> 19: ## Responsibilities of a Reviewer
>>> 20:
>>> 21: As a [Reviewer](https://openjdk.org/bylaws#reviewer) you have a responsibility to make sure changes are sound and aline with the general direction of the area. If you, as a [Reviever](https://openjdk.org/bylaws#reviewer), review a change in an area that you don't know well you probably shouldn't be the one to approve the change.
>>
>> s/aline/align/
>
> Just to expand here though, a change can often touch on multiple areas and require reviews by multiple people. It is common to give a partial review (for your area) but also to click the "approve" button to indicate approval for that area. Authors will typically (informally) collect sufficient reviews to cover all aspects of the change - or more formally you can bump the number of needed reviewers to match the number of different areas.
>
> Edit: I see this is touched on later.
Typo fixed.
-------------
PR Review Comment: https://git.openjdk.org/guide/pull/131#discussion_r1693211750
More information about the guide-dev
mailing list