RFR: New section Making a change [v2]
Jesper Wilhelmsson
jwilhelm at openjdk.org
Fri Jul 26 14:54:23 UTC 2024
On Tue, 9 Jul 2024 00:56:15 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Removed todo entry for the CSR section
>
> src/guide/reviewing-and-sponsoring-a-change.md line 11:
>
>> 9: Two of the most important contributions you can make in the OpenJDK community are to review and sponsor changes for other developers. All changes needs to be reviewed. Many changes even need to be reviewed by more than one person. This means that in order to enable a fast-pased development experience, all developers need to review more changes then they produce themself.
>> 10:
>> 11: If you are new to an area, reviewing changes is also a great way to learn the code and see what general styles and types of changes that are relevant in the area. Be mindful though, if you don't know the area well you should state this in your review comments.
>
> s/changes that are/changes are/
Fixed.
-------------
PR Review Comment: https://git.openjdk.org/guide/pull/131#discussion_r1693211916
More information about the guide-dev
mailing list