errata for Contributed-by

Mark Reinhold mr at sun.com
Thu Mar 6 21:13:32 PST 2008


> Date: Thu, 06 Mar 2008 15:12:08 -0800 (PST)
> From: iris clark <iris at sun.com>

>> Date: Thu, 06 Mar 2008 10:18:36 -0800
>> From: jonathan.gibbons at sun.com
>> 
>> http://openjdk.java.net/guide/producingChangeset.html#create lists this
>> example for a changeset message:
>> 
>> 1234567: NPE thrown on FileInputStream("")
>> Summary: Rewrite precondition-checking code in io.c
>> Reviewed-by: mr
>> Contributed-by: Ben Bitdiddle <ben at bits.org>
>> 
>> In practice, it seems jcheck requires a real email address. At any
>> rate, it gave me an unspecific "invalid contributor attribution" when
>> I tried to follow the example.
> 
> Oops.  When I was removing "@" from e-mail addresses, I was just a
> tiny bit too aggressive.
> 
> :(
> 
> I'll have to see what jcheck looks for.  I'm hoping that it allows the
> something like this:
> 
>   Contributed-by: Ben Bitdiddle <ben at bits.org>
> 
> Rather than just
> 
>   Contributed-by: ben at bits.org

Yes, it allows the former long form, and in fact that's preferable.
The long form will make the CONTRIBUTORS file (or whatever we wind
up calling it) easier to read.

Hmm, perhaps jcheck should require the long form?  Some people don't
ever use their full names, and are just known by bare e-mail addresses,
so I suppose that won't work.

- Mark



More information about the guide-discuss mailing list