[PATCH] jcheck: allow bug id line to be ignored
mark.reinhold at oracle.com
mark.reinhold at oracle.com
Mon Apr 8 15:19:13 PDT 2013
2013/3/21 5:07 -0700, omajid at redhat.com:
> The following webrev adds a new configure option "ignore" for bugids. If
> it is set, then jcheck does not validate the bug summary line at all.
>
> http://cr.openjdk.java.net/~omajid/webrevs/jcheck-ignore-bug-line/00/
>
> This is needed over at the JDK6 project so we can push commits with
> Oracle's bug ids (backports from 7 and 8) as well as bugs with
> "OPENJDK6-XXXX" bug ids. ...
This is a fine change in principle. I don't understand, though, why
you need your first patch (embedded in this patch) to store bugids as
strings rather than numbers. You're not going to validate bugids that
aren't pure numbers, so why bother with that change?
Please add a case or two to the unit tests to cover this new option.
The tests for configuration options are at the end of runtests.sh.
- Mark
More information about the hg-tools-dev
mailing list