[PATCH] jcheck: allow bug id line to be ignored

[Omair Majid]

Hi Mark,

On 04/08/2013 06:19 PM, mark.reinhold at oracle.com wrote:
> 2013/3/21 5:07 -0700, omajid at redhat.com:
>> The following webrev adds a new configure option "ignore" for bugids. If
>> it is set, then jcheck does not validate the bug summary line at all.
>>
>> http://cr.openjdk.java.net/~omajid/webrevs/jcheck-ignore-bug-line/00/
>>
>> This is needed over at the JDK6 project so we can push commits with
>> Oracle's bug ids (backports from 7 and 8) as well as bugs with
>> "OPENJDK6-XXXX" bug ids. ...
> 
> This is a fine change in principle.  I don't understand, though, why
> you need your first patch (embedded in this patch) to store bugids as
> strings rather than numbers.  You're not going to validate bugids that
> aren't pure numbers, so why bother with that change?

Even thought the bug ids are never used, repo_bugids is called when the
checker object is created:
544     ch = checker(ui, repo, repo_bugids(ui, repo), strict, lax)

And repo_bugids method ends up doing:
209                 b = int(m.group(1))

To find the bug 'number'.

I can avoid this by delaying the invocation of repo_bugids until
necessary, but I went with minimal changes for this patch.

> Please add a case or two to the unit tests to cover this new option.
> The tests for configuration options are at the end of runtests.sh.

Thank you for the pointers; I will post an updated webrev that includes
tests.

Thanks,
Omair

-- 
PGP Key: 66484681 (http://pgp.mit.edu/)
Fingerprint = F072 555B 0A17 3957 4E95  0056 F286 F14F 6648 4681