Request for review (L): 6797305: Add LoadUB and LoadUI opcode class

Christian Thalinger Christian.Thalinger at Sun.COM
Tue Mar 3 10:08:36 PST 2009


On Tue, 2009-03-03 at 09:56 -0800, Tom Rodriguez wrote:
> > 2. What about adding load and store assembler instruction like on x86
> > with an Address argument, e.g.
> >
> >  inline void lduw(Address a, Register d);
> 
> We could, though fixing that along with what you are doing seems like  
> loading more than want into your change.  I'd leave the sparc  
> encodings along for now and we can fix it later to support the Address  
> stuff.

Yeah, I will do that.  I will post a webrev later and open a new CR for
the Address changes on SPARC.

> > The
> >
> >  inline void lduw(const Address& a, Register d, int offset = 0);
> >
> > seems to be doing something different, although I don't know yet what.
> 
> I've never understood what the Address variants do in the sparc  
> assembler.  They're very strange.  Any change to use Address more  
> normally would require changing those too I think.

:-)

-- Christian




More information about the hotspot-compiler-dev mailing list